Dev: Include extension name in error message

LimeSurvey · Oct 5, 2018 · 04636b9 · 04636b9
1 parent fb43a2a
commit 04636b9
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/application/core/plugins/UpdateCheck/UpdateCheck.php b/application/core/plugins/UpdateCheck/UpdateCheck.php
@@ -87,7 +87,7 @@ public function checkAll()
     {
         $service = \Yii::app()->extensionUpdaterServiceLocator;
 
-        // Get one updater class for each extension type (PluginUpdater, ThemeUpdater, etc).
+        // Get one updater class for each extension.
         list($updaters, $errors) = $service->getAllUpdaters();
 
         /** @var string[] */
@@ -106,18 +106,20 @@ public function checkAll()
                     $messages[] = $updater->getVersionMessage($versions);
                 }
             } catch (\Throwable $ex) {
-                $errors[] = $ex->getMessage();
+                $errors[] = $updater->getExtensionName() . ': ' . $ex->getMessage();
             }
         }
 
+        // Compose notification.
         if ($messages || $errors) {
             $superadmins = User::model()->getSuperAdmins();
             $title        = $foundSecurityVersion ? gT('Security updates available') : gT('Updates available');
             $displayClass = $foundSecurityVersion ? 'danger' : '';
             $importance   = $foundSecurityVersion ? Notification::HIGH_IMPORTANCE : Notification::NORMAL_IMPORTANCE;
             $message = implode($messages);
             if ($errors) {
-                $message .= '<hr/><i class="fa fa-warning"></i>&nbsp;' . gT('Errors happened during the update check. Please notify the extension authors for support.')
+                $message .= '<hr/><i class="fa fa-warning"></i>&nbsp;'
+                    . gT('Errors happened during the update check. Please notify the extension authors for support.')
                     . '<ul>'
                     . '<li>' . implode('</li><li>', $errors) . '</li>';
             }