Fixed issue #13794: RPC add_response reports error, still inserts a r…

…esponse record
LimeSurvey · Jun 21, 2018 · 09b03e2 · 09b03e2
1 parent f392f4d
commit 09b03e2
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/application/helpers/remotecontrol/remotecontrol_handle.php b/application/helpers/remotecontrol/remotecontrol_handle.php
@@ -2535,6 +2535,8 @@ public function remind_participants($sSessionKey, $iSurveyID, $iMinDaysBetween =
      * @param int $iSurveyID ID of the Survey to insert responses
      * @param array $aResponseData The actual response
      * @return int|array The response ID
+     * @todo Need to clean up return array, especially the case when response was added but file not uploaded.
+     * @todo See discussion: https://bugs.limesurvey.org/view.php?id=13794
      */
     public function add_response($sSessionKey, $iSurveyID, $aResponseData)
     {
@@ -2597,7 +2599,10 @@ public function add_response($sSessionKey, $iSurveyID, $aResponseData)
                         }
 
                         if (!rename($sFileTempName, $sFileRealName)) {
-                            return array('status' => 'Unable to move files '.$sFileTempName.' '.$sFileRealName);
+                            return array(
+                                'status'    => 'Unable to move files '.$sFileTempName.' '.$sFileRealName,
+                                'result_id' => $result_id
+                            );
                         }
                     }