Fixed issue: User can accidentally change certain survey settings aft…

…er survey is already active
LimeSurvey · Aug 25, 2015 · 0d28491 · 0d28491
1 parent dfe76ec
commit 0d28491
Showing 1 changed file with 10 additions and 7 deletions.
diff --git a/application/controllers/admin/surveyadmin.php b/application/controllers/admin/surveyadmin.php
@@ -1,4 +1,4 @@
-<?php
+n <?php
 
 if (!defined('BASEPATH'))
     exit('No direct script access allowed');
@@ -1413,16 +1413,19 @@ function update($iSurveyId)
         $oSurvey->admin =  Yii::app()->request->getPost('admin');
         $oSurvey->expires =  $expires;
         $oSurvey->startdate =  $startdate;
-        $oSurvey->anonymized = App()->request->getPost('anonymized');
         $oSurvey->faxto = App()->request->getPost('faxto');
         $oSurvey->format = App()->request->getPost('format');
-        $oSurvey->savetimings = App()->request->getPost('savetimings');
         $oSurvey->template = Yii::app()->request->getPost('template');
         $oSurvey->assessments = App()->request->getPost('assessments');
         $oSurvey->additional_languages = implode(' ',Yii::app()->request->getPost('additional_languages',array()));
-        $oSurvey->datestamp = App()->request->getPost('datestamp');
-        $oSurvey->ipaddr = App()->request->getPost('ipaddr');
-        $oSurvey->refurl = App()->request->getPost('refurl');
+        if ($oSurvey->active!='Y')
+        {
+            $oSurvey->anonymized = App()->request->getPost('anonymized');
+            $oSurvey->savetimings = App()->request->getPost('savetimings');
+            $oSurvey->datestamp = App()->request->getPost('datestamp');
+            $oSurvey->ipaddr = App()->request->getPost('ipaddr');
+            $oSurvey->refurl = App()->request->getPost('refurl');
+        }
         $oSurvey->publicgraphs = App()->request->getPost('publicgraphs');
         $oSurvey->usecookie = App()->request->getPost('usecookie');
         $oSurvey->allowregister = App()->request->getPost('allowregister');
@@ -1499,7 +1502,7 @@ function update($iSurveyId)
         cleanLanguagesFromSurvey($iSurveyId,implode(" ",$oSurvey->additionalLanguages));
         fixLanguageConsistency($iSurveyId,implode(" ",$oSurvey->additionalLanguages));
 
-        // Url params in json 
+        // Url params in json
         $aURLParams=json_decode(Yii::app()->request->getPost('allurlparams'),true);
         SurveyURLParameter::model()->deleteAllByAttributes(array('sid'=>$iSurveyId));
         if(isset($aURLParams))