Fixed issue #7105: Bad error handling on invalid lastgroup POST

LimeSurvey · Dec 22, 2012 · 0df3fdf · 0df3fdf
1 parent 87cacbf
commit 0df3fdf
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/application/libraries/Save.php b/application/libraries/Save.php
@@ -281,7 +281,7 @@ function set_answer_time()
             $setField = $_POST['lastanswer'];
         }
         elseif (isset($_POST['lastgroup']))
-        {
+        {    
             $setField = $_POST['lastgroup'];
         }
         $passedTime = round(microtime(true) - $_POST['start_time'],2);
@@ -293,7 +293,9 @@ function set_answer_time()
         }
         else
         {
+            $aColumnNames=Survey_timings::model($thissurvey['sid'])->getTableSchema()->columnNames;
             $setField .= "time";
+            if (!in_array($setField,$aColumnNames)) die('Invalid last group timing fieldname');
             $setField = Yii::app()->db->quoteColumnName($setField);
             $query = "UPDATE {{survey_{$thissurvey['sid']}_timings}} SET "
             ."interviewtime =  (CASE WHEN interviewtime IS NULL THEN 0 ELSE interviewtime END) + " .$passedTime .","