Fixed issue #7210: When deleting a question group all relevance equat…

…ions in the survey are set to '1'
LimeSurvey · Jan 18, 2013 · 1adf69d · 1adf69d
1 parent da872d9
commit 1adf69d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/application/controllers/admin/questiongroup.php b/application/controllers/admin/questiongroup.php
@@ -244,10 +244,8 @@ public function delete($iSurveyId, $iGroupId)
             }
             else
                 Yii::app()->user->setFlash('flashmessage', $clang->gT('Group could not be deleted'));
-
-            $this->getController()->redirect($this->getController()->createUrl('admin/survey/sa/view/surveyid/' . $iSurveyId));
-
             LimeExpressionManager::UpgradeConditionsToRelevance($iSurveyId);
+            $this->getController()->redirect($this->getController()->createUrl('admin/survey/sa/view/surveyid/' . $iSurveyId));
         }
     }
 

diff --git a/application/views/admin/survey/QuestionGroups/questiongroupbar_view.php b/application/views/admin/survey/QuestionGroups/questiongroupbar_view.php
@@ -45,7 +45,7 @@
                     // TMSW Conditions->Relevance:  Should be allowed to delete group even if there are conditions/relevance, since separate view will show exceptions
 
                     { ?>
-                    <a href='<?php echo $this->createUrl("admin/questiongroup/sa/view/surveyid/$surveyid/gid/$gid"); ?>' onclick="alert('<?php $clang->eT("Impossible to delete this group because there is at least one question having a condition on its content","js"); ?>')">
+                    <a href='<?php echo $this->createUrl("admin/survey/sa/view/surveyid/$surveyid/gid/$gid"); ?>' onclick="alert('<?php $clang->eT("Impossible to delete this group because there is at least one question having a condition on its content","js"); ?>'); return false;">
                         <img src='<?php echo $imageurl; ?>delete_disabled.png' alt='<?php $clang->eT("Delete current question group"); ?>' width="<?php echo $iIconSize;?>" height="<?php echo $iIconSize;?>"/></a>
                     <?php }
                 }