Fixed issue #13306: console.ls.error() doesn't log

LimeSurvey · Feb 6, 2018 · 22158e2 · 22158e2
1 parent 0ffb3de
commit 22158e2
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 13 deletions.
diff --git a/assets/packages/lslog/build/lslog.js b/assets/packages/lslog/build/lslog.js
@@ -71,9 +71,9 @@ var ConsoleShim = function () {
         }
     }, {
         key: '_insertParamToArguments',
-        value: function _insertParamToArguments() {
+        value: function _insertParamToArguments(rawArgs) {
             if (this.param !== '') {
-                var args = Array.from(arguments);
+                var args = [].concat(_toConsumableArray(rawArgs));
                 args.unshift(this.param);
                 return args;
             }
@@ -131,9 +131,7 @@ var ConsoleShim = function () {
             }
             var args = this._insertParamToArguments(arguments);
             if (typeof console.group === 'function') {
-                var _console$log;
-
-                (_console$log = console.log).call.apply(_console$log, [console].concat(_toConsumableArray(args)));
+                console.log.apply(console, args);
                 return;
             }
             args.shift();
@@ -199,7 +197,7 @@ var ConsoleShim = function () {
         value: function error() {
             var args = this._insertParamToArguments(arguments);
             if (typeof console.error === 'function') {
-                console.error.apply(args);
+                console.error.apply(console, args);
                 return;
             }
 
@@ -211,7 +209,7 @@ var ConsoleShim = function () {
         value: function warn() {
             var args = this._insertParamToArguments(arguments);
             if (typeof console.warn === 'function') {
-                console.warn.apply(args);
+                console.warn.apply(console, args);
                 return;
             }
 

diff --git a/assets/packages/lslog/build/lslog.min.js b/assets/packages/lslog/build/lslog.min.js
diff --git a/assets/packages/lslog/src/lslog.js b/assets/packages/lslog/src/lslog.js
@@ -38,9 +38,9 @@ class ConsoleShim {
             return err;
         }
     }
-    _insertParamToArguments(){
+    _insertParamToArguments(rawArgs){
         if(this.param !== ''){
-            let args = Array.from(arguments);
+            let args = [...rawArgs];
             args.unshift(this.param);
             return args;
         }
@@ -79,7 +79,7 @@ class ConsoleShim {
         if(this.silencer) { return; }
         const args = this._insertParamToArguments(arguments);
         if (typeof console.group === 'function') {
-            console.log.call(console, ...args);
+            console.log.apply(console, args);
             return;
         }
         args.shift();
@@ -133,7 +133,7 @@ class ConsoleShim {
     error() {
         const args = this._insertParamToArguments(arguments);
         if (typeof console.error === 'function') {
-            console.error.apply(args);
+            console.error.apply(console,args);
             return;
         }
 
@@ -145,7 +145,7 @@ class ConsoleShim {
     warn() {
         const args = this._insertParamToArguments(arguments);
         if (typeof console.warn === 'function') {
-            console.warn.apply(args);
+            console.warn.apply(console,args);
             return;
         }