Fixed issue #15973: Invalid submitfailed received

Dev: PDOStatement::rowCount are unstable and unsure. Dev: then don't use it if submitdate are not updated
LimeSurvey · Mar 16, 2020 · 24b0b4e · 24b0b4e
1 parent 24bb6f6
commit 24b0b4e
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/application/helpers/expressions/em_manager_helper.php b/application/helpers/expressions/em_manager_helper.php
@@ -5681,7 +5681,7 @@ private function _UpdateValuesInDatabase($finished=false)
                             } else {
                                 $submitdate = date("Y-m-d H:i:s",mktime(0,0,0,1,1,1980));
                             }
-                            if (!Response::model($this->sid)->updateByPk($oResponse->id,array('submitdate'=>$submitdate))) {
+                            if ($submitdate != $oResponse->submitdate && !Response::model($this->sid)->updateByPk($oResponse->id,array('submitdate'=>$submitdate))) {
                                 LimeExpressionManager::addFrontendFlashMessage('error', $this->gT('An error happened when trying to submit your response.'), $this->sid);
                             }
                         }