Fixed issue: Memory usage on integrity check too big

LimeSurvey · Nov 2, 2012 · 25ac0dc · 25ac0dc
1 parent 658f835
commit 25ac0dc
Showing 1 changed file with 2 additions and 6 deletions.
diff --git a/application/controllers/admin/checkintegrity.php b/application/controllers/admin/checkintegrity.php
@@ -435,15 +435,11 @@ protected function _checkintegrity()
         /**********************************************************************/
         /*     Check question attributes                                      */
         /**********************************************************************/
-        $question_attributes = Question_attributes::model()->findAll();
+        $question_attributes = Question_attributes::model()->findAllBySql('select qid from {{question_attributes}} where qid not in (select qid from {{questions}})');
         if (Question_attributes::model()->hasErrors()) safeDie(Question_attributes::model()->getError());
         foreach ($question_attributes as $question_attribute)
         {
-            $iRowCount = Questions::model()->countByAttributes(array('qid' => $question_attribute['qid']));
-            if (Questions::model()->hasErrors()) safeDie(Questions::model()->getError());
-            if (!$iRowCount) {
-                $aDelete['questionattributes'][] = array('qid' => $question_attribute['qid']);
-            }
+            $aDelete['questionattributes'][] = array('qid' => $question_attribute['qid']);
         } // foreach