LSC-267: added dp update for latest changes in failed_emails

LSC-267: fixed responselink display condition
LimeSurvey · Sep 12, 2022 · 3a6ef60 · 3a6ef60
1 parent 00d0a04
commit 3a6ef60
Show file tree

Hide file tree

Showing 3 changed files with 29 additions and 2 deletions.
diff --git a/application/config/version.php b/application/config/version.php
@@ -12,7 +12,7 @@
  */
 
 $config['versionnumber'] = '5.4.0';
-$config['dbversionnumber'] = 490;
+$config['dbversionnumber'] = 491;
 $config['buildnumber'] = '';
 $config['updatable'] = true;
 $config['templateapiversion']  = 3;

diff --git a/application/helpers/update/updates/Update_491.php b/application/helpers/update/updates/Update_491.php
@@ -0,0 +1,26 @@
+<?php
+
+namespace LimeSurvey\Helpers\Update;
+
+class Update_491 extends DatabaseUpdateBase
+{
+    public function up()
+    {
+        $responseidColumn = $this->db->getSchema()->getTable('{{failed_emails}}')->getColumn('responseid');
+        if ($responseidColumn === null) {
+            $this->db->createCommand()->addColumn(
+                '{{failed_emails}}',
+                'responseid',
+                "integer NOT NULL"
+            );
+        }
+        $resendVarsColumn = $this->db->getSchema()->getTable('{{failed_emails}}')->getColumn('resend_vars');
+        if ($resendVarsColumn === null) {
+            $this->db->createCommand()->addColumn(
+                '{{failed_emails}}',
+                'resend_vars',
+                "text NOT NULL"
+            );
+        }
+    }
+}
diff --git a/application/models/FailedEmail.php b/application/models/FailedEmail.php
@@ -210,7 +210,8 @@ public function getButtons(): string
      */
     public function getResponseUrl(): string
     {
-        if (Survey::model()->findByPk($this->surveyid)->hasResponsesTable) {
+        $survey = Survey::model()->findByPk($this->surveyid);
+        if ( $survey !== null && $survey->hasResponsesTable) {
             $response = Response::model($this->surveyid)->findByPk($this->responseid);
             if (!empty($response)) {
                 $responseUrl = App()->createUrl("responses/view/", ['surveyId' => $this->surveyid, 'id' => $this->responseid]);