Commit
…n to head.twig
- Loading branch information
There are no files selected for viewing
4 comments
on commit 40b0aa4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then we must remove it from limesurvey package ? Only for default based template ?
https://github.com/LimeSurvey/LimeSurvey/blob/develop/assets/packages/limesurvey/survey.js#L136
Here : it's in default template , but function is called for any template.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't noticed it was also defined in package. II just moved it from surveyRuntime to the view, but if it's already registered via the package method, then it can be simply removed.
I just wanted to give the possibility to template designers to remove those scripts if they handle it in their own way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Javascript function is in package :) , package can not register script function call
Maybe whole ActionLink
can be only in template , but did you remind all bug when you add this link : -The link at the top didn't work- etc ...
Then if a javascript link is created by core , core MUST offer a way to use it.
Maybe we must add this script call in views directly ? But then call script X times (but loaded finally 1 time : same name)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
timming? or timing?