Fixed issue #17149: UserGroup hasUser() return true for superadmin (#…

…1789) Co-authored-by: Daniel Fowlkes <daniel_g_fowlkes@omb.eop.gov>
LimeSurvey · Mar 5, 2021 · 4367fec · 4367fec
1 parent b81067f
commit 4367fec
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/application/models/UserGroup.php b/application/models/UserGroup.php
@@ -433,7 +433,7 @@ public function searchMine($isMine)
     public function hasUser($uid)
     {
         // superadmin is part of all groups
-        if (!Permission::model()->hasGlobalPermission('superadmin', 'read')) {
+        if (Permission::model()->hasGlobalPermission('superadmin', 'read')) {
             return true;
         }
         $userInGroup = UserInGroup::model()->findByAttributes(['ugid'=>$this->ugid], 'uid=:uid', [':uid'=>$uid]);