Fixed issue #17637: wrong question order (#2139)

Dev gid was not used by storeNewQuestionData() as ajax request passes it in question data, not as request param.
LimeSurvey · Nov 12, 2021 · 48e3ce0 · 48e3ce0
1 parent 6ad2912
commit 48e3ce0
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/application/controllers/QuestionAdministrationController.php b/application/controllers/QuestionAdministrationController.php
@@ -2434,8 +2434,7 @@ private function storeNewQuestionData($aQuestionData = null, $subquestion = fals
     {
         $iSurveyId = $aQuestionData['sid'];
         $oSurvey = Survey::model()->findByPk($iSurveyId);
-        // TODO: Don't read request from private methods.
-        $iQuestionGroupId = (int) App()->request->getParam('gid'); //the group id the question belongs to
+        $iQuestionGroupId = (int) $aQuestionData['gid'];
         $type = SettingsUser::getUserSettingValue(
             'preselectquestiontype',
             null,