Fixed issue #6347: display of question text different in 1.92+ and 2.…

…0 when view question in admin mode Dev Partial fix
LimeSurvey · Jul 23, 2012 · 5013658 · 5013658
1 parent 9bd682d
commit 5013658
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/application/core/Survey_Common_Action.php b/application/core/Survey_Common_Action.php
@@ -352,7 +352,6 @@ function _questionbar($iSurveyId, $gid, $qid, $action = null)
         foreach ($qrresult as $qrrow)
         {
             $qrrow = $qrrow->attributes;
-            $qrrow = array_map('flattenText', $qrrow);
             if (hasSurveyPermission($iSurveyId, 'surveycontent', 'read'))
             {
                 if (count(Survey::model()->findByPk($iSurveyId)->additionalLanguages) != 0)

diff --git a/application/views/admin/survey/Question/questionbar_view.php b/application/views/admin/survey/Question/questionbar_view.php
@@ -166,20 +166,20 @@
             <?php $clang->eT("Question:"); ?></strong></td><td>
             <?php
                 templatereplace($qrrow['question']);
-                echo LimeExpressionManager::GetLastPrettyPrintExpression();
+                echo FlattenText(LimeExpressionManager::GetLastPrettyPrintExpression(), true);
         ?></td></tr>
     <tr><td><strong>
             <?php $clang->eT("Help:"); ?></strong></td><td>
             <?php
                 if (trim($qrrow['help'])!=''){
                     templatereplace($qrrow['help']);
-                    echo LimeExpressionManager::GetLastPrettyPrintExpression();
+                    echo FlattenText(LimeExpressionManager::GetLastPrettyPrintExpression(), true);
             } ?>
         </td></tr>
     <?php if ($qrrow['preg'])
         { ?>
         <tr ><td><strong>
-                <?php $clang->eT("Validation:"); ?></strong></td><td><?php echo $qrrow['preg']; ?>
+                <?php $clang->eT("Validation:"); ?></strong></td><td><?php echo htmlspecialchars($qrrow['preg']); ?>
             </td></tr>
         <?php } ?>
 
@@ -252,7 +252,7 @@
         <tr>
             <td><?php echo $aAdvancedSetting['caption'];?>:</td>
             <td><?php
-                    if ($aAdvancedSetting['i18n']==false)  echo $aAdvancedSetting['value']; else echo $aAdvancedSetting[$baselang]['value']?>
+                    if ($aAdvancedSetting['i18n']==false)  echo htmlspecialchars($aAdvancedSetting['value']); else echo htmlspecialchars($aAdvancedSetting[$baselang]['value'])?>
             </td>
         </tr>
         <?php } ?>