Dev: Abort if response is not found in the database

LimeSurvey · Feb 21, 2020 · 583d666 · Shnoulle · Feb 21, 2020 · olleharstedt
1 parent f9820ab
commit 583d666
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/application/helpers/expressions/em_manager_helper.php b/application/helpers/expressions/em_manager_helper.php
@@ -5622,6 +5622,12 @@ private function _UpdateValuesInDatabase($finished=false)
                 if (isset($_SESSION[$this->sessid]['srid']) && $this->surveyOptions['active'])
                 {
                     $oResponse = Response::model($this->sid)->findByPk($_SESSION[$this->sessid]['srid']);
+                    if (empty($oResponse)) {
+                        // This can happen if admin deletes incomple response while survey is running.
+                        $message = submitfailed('', $this->gT('Error on response update'));
+                        LimeExpressionManager::addFrontendFlashMessage('error', $message, $this->sid);
+                        return;
+                    }
                     if ($oResponse->submitdate == null || Survey::model()->findByPk($this->sid)->alloweditaftercompletion == 'Y') {
                         $oResponse->setAttributes($aResponseAttributes, false);
                         if (!$oResponse->encryptSave())