Skip to content

Commit

Permalink
dev: refactoring controller responses.php (admin/respones) ResponsesC…
Browse files Browse the repository at this point in the history
…ontroller.php
  • Loading branch information
ptelu committed Sep 28, 2021
1 parent 381fc5a commit 58dbdd6
Show file tree
Hide file tree
Showing 59 changed files with 2,017 additions and 2,510 deletions.
4 changes: 2 additions & 2 deletions application/config/version.php
Expand Up @@ -12,9 +12,9 @@
*/

$config['versionnumber'] = '5.2.0-dev';
$config['dbversionnumber'] = 475;
$config['dbversionnumber'] = 476;
$config['buildnumber'] = '';
$config['updatable'] = true;
$config['templateapiversion'] = 3;
$config['assetsversionnumber'] = '30240';
$config['assetsversionnumber'] = '30241';
return $config;
2 changes: 1 addition & 1 deletion application/controllers/AdminController.php
Expand Up @@ -366,7 +366,7 @@ public function getActionClasses()
'questionthemes' => 'questionthemes',
'quotas' => 'quotas',
'remotecontrol' => 'remotecontrol',
'responses' => 'responses',
// 'responses' => 'responses',
'saved' => 'saved',
'statistics' => 'statistics',
// 'survey' => 'surveyadmin',
Expand Down
1,028 changes: 1,028 additions & 0 deletions application/controllers/ResponsesController.php

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions application/controllers/admin/dataentry.php
Expand Up @@ -406,7 +406,7 @@ public function import($surveyid)
}
Yii::app()->session['flashmessage'] = sprintf(gT("%s old response(s) and according timings were successfully imported."), $imported, $iRecordCountT);
}
$this->getController()->redirect(array("/admin/responses/sa/index/", 'surveyid' => $surveyid));
$this->getController()->redirect(["/responses/index/", 'surveyId' => $surveyid]);
}
}

Expand Down Expand Up @@ -1494,7 +1494,7 @@ public function update()
Yii::app()->setFlashMessage(sprintf(gT("The response record %s was updated."), $id));
}
if (Yii::app()->request->getPost('close-after-save') == 'true') {
$this->getController()->redirect($this->getController()->createUrl("admin/responses/sa/view/surveyid/{$surveyid}/id/{$id}"));
$this->getController()->redirect($this->getController()->createUrl("responses/view/", ['surveyId' => $surveyid, 'id' => $id]));
} else {
$this->getController()->redirect($this->getController()->createUrl("admin/dataentry/sa/editdata/subaction/edit/surveyid/{$surveyid}/id/{$id}"));
}
Expand Down
2 changes: 1 addition & 1 deletion application/controllers/admin/expressions.php
Expand Up @@ -306,4 +306,4 @@ protected function _renderWrappedTemplate($sAction = 'expressions', $aViewUrls =
header("Content-type: text/html; charset=UTF-8"); // needed for correct UTF-8 encoding
parent::_renderWrappedTemplate($sAction, $aViewUrls, $aData, $sRenderFile);
}
}
}

7 comments on commit 58dbdd6

@olleharstedt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ptelu This commit broke the CI

@olleharstedt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐮 🐄

@Shnoulle
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cow cow2

? What is the meaning?

@olleharstedt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cow cow2

? What is the meaning?

Mooo.

@Shnoulle
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cow cow2

? What is the meaning?

Mooo.

:( still unclear for me .

@olleharstedt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Shnoulle It's just an internal joke, Denis. :)

@ptelu
Copy link
Contributor Author

@ptelu ptelu commented on 58dbdd6 Sep 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fixed, also will probably add a task to create a config file that can be used for selenium. Since most problems when testing are related to it.

Please sign in to comment.