Dev: Some more EM tests

LimeSurvey · Aug 28, 2017 · 5ced08c · 5ced08c
1 parent 9e2b15c
commit 5ced08c
Showing 1 changed file with 67 additions and 11 deletions.
diff --git a/tests/helpers/ExpressionCoreHelperTest.php b/tests/helpers/ExpressionCoreHelperTest.php
@@ -152,6 +152,50 @@ public function testCompareNumberLtSpace()
         $this->compareExpression($sgqa, $value, $expression);
     }
 
+    /**
+     * Expression: '3' < 'A'
+     */
+    public function testNumberLtLetter()
+    {
+        $sgqa = '563168X136X5376';
+        $expression = '((563168X136X5376.NAOK < "A"))';
+        $value = '3';
+        $this->compareExpression($sgqa, $value, $expression);
+    }
+
+    /**
+     * '3' <= ' '
+     */
+    public function testNumberLeSpace()
+    {
+        $sgqa = '563168X136X5376';
+        $expression = '((563168X136X5376.NAOK <= " "))';
+        $value = '3';
+        $this->compareExpression($sgqa, $value, $expression);
+    }
+
+    /**
+     * '3' <= ''
+     */
+    public function testNumberLeEmpty()
+    {
+        $sgqa = '563168X136X5376';
+        $expression = '((563168X136X5376.NAOK <= ""))';
+        $value = '3';
+        $this->compareExpression($sgqa, $value, $expression);
+    }
+
+    /**
+     * '' <= ' '
+     */
+    public function testEmptyLeSpace()
+    {
+        $sgqa = '563168X136X5376';
+        $expression = '((563168X136X5376.NAOK <= " "))';
+        $value = '';
+        $this->compareExpression($sgqa, $value, $expression);
+    }
+
     /**
      * Expression: '' > ' '
      */
@@ -233,9 +277,23 @@ public function testNumberPlusString()
         $this->compareExpression($sgqa, $value, $expression, $jsonEncodeResult);
     }
 
+    /**
+     * Expression: 3 + 2
+     * @todo Need LEMval() to work.
+     */
+    public function testNumberPlusNumber()
+    {
+        $sgqa = '563168X136X5376';
+        $expression = '((563168X136X5376.NAOK + 2))';
+        $value = 3;
+        $jsonEncodeResult = true;
+        //$this->compareExpression($sgqa, $value, $expression, $jsonEncodeResult);
+    }
+
     /**
      * @param string $sgqa
      * @param string $expression
+     * @param boolean $jsonEncode If true, run json_encode on PHP eval result. Good for when node returns boolean.
      * @return void
      */
     protected function compareExpression($sgqa, $value, $expression, $jsonEncode = true)
@@ -244,14 +302,14 @@ protected function compareExpression($sgqa, $value, $expression, $jsonEncode = t
         $_SESSION['survey_563168'][$sgqa] = $value;
 
         $em = new \ExpressionManager();
-        $limeEm = \LimeExpressionManager::singleton();
-        $limeEm->setVariableAndTokenMappingsForExpressionManager('563168');
-        $limeEm->setKnownVars(
+        $lem = \LimeExpressionManager::singleton();
+        $lem->setVariableAndTokenMappingsForExpressionManager('563168');
+        $lem->setKnownVars(
             [
                 $sgqa => [
                     'sgqa' => $sgqa,
-                    'type' => 'N',
-                    //'jsName' => 'anything'  This will trigger LEMval()
+                    'type' => 'N'
+                    //'jsName' => 'anything'  // This will trigger LEMval()
                 ]
             ]
         );
@@ -284,13 +342,11 @@ protected function runNode($js)
         // Only use single quotes.
         $js = str_replace('"', "'", $js);
         $output = [];
-        exec(
-            sprintf(
-                'node -p "%s"',
-                $js
-            ),
-            $output
+        $command = sprintf(
+            'node -p "%s"',
+            $js
         );
+        exec($command, $output);
         return $output;
     }