Fixed issue #17010: Admin personal setting not implemented (#1740)

Default question type & Lock question organizer are fixed.
LimeSurvey · Feb 8, 2021 · 621664f · 621664f
1 parent ec96f91
commit 621664f
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/application/controllers/QuestionAdministrationController.php b/application/controllers/QuestionAdministrationController.php
@@ -88,7 +88,7 @@ public function actionCreate($surveyid)
             throw new Exception('Internal error: Found no survey with id ' . $surveyid);
         }
 
-        $oQuestion = $this->getQuestionObject(null, 'F', null);
+        $oQuestion = $this->getQuestionObject(null, null, null);
         $oQuestion->sid = $surveyid;
 
         $this->aData['showSaveAndNewGroupButton'] = true;

diff --git a/application/models/QuestionCreate.php b/application/models/QuestionCreate.php
@@ -8,7 +8,7 @@ class QuestionCreate extends Question
     /**
      * @todo This is a factory method, not a singleton. Rename to make() or create().
      */
-    public static function getInstance($iSurveyId, $type)
+    public static function getInstance($iSurveyId, $type = null)
     {
         $oSurvey = Survey::model()->findByPk($iSurveyId);
         if (empty($oSurvey)) {

diff --git a/application/views/layouts/sidemenu.php b/application/views/layouts/sidemenu.php
@@ -56,7 +56,7 @@
             basemenus: '.json_encode($menuObjectArray).',
             updateOrderLink: "'.$updateOrderLink.'",
             unlockLockOrganizerUrl: "'.$unlockLockOrganizerUrl.'",
-            allowOrganizer: '.(SettingsUser::getUserSettingValue('lock_organizer') ? '1' : '0').',
+            allowOrganizer: '.(SettingsUser::getUserSettingValue('lock_organizer') ? '0' : '1').',
             translate: '
             .json_encode(
                 [