Skip to content

Commit

Permalink
Dev: Copy EM tests from master branch
Browse files Browse the repository at this point in the history
  • Loading branch information
@olleharstedt
olleharstedt committed Nov 1, 2017
1 parent 9bad305 commit 6a9a1f1
Show file tree
Hide file tree
Showing 2 changed files with 34 additions and 387 deletions.
2 changes: 1 addition & 1 deletion tests/helpers/ExpressionCoreAux.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
/**
* Helper class for expression core tests.
*/
class ExpressionCoreAux extends \PHPUnit_Framework_TestCase
class ExpressionCoreAux extends TestCase

This comment has been minimized.

Sign in to view

Copy link
@TonisOrmisson

TonisOrmisson Dec 29, 2017

Collaborator

Is this a TestCase at all? Looks like it should not extend TestCase?
Anyway the constructor does not match the TestCase constructor, so it caught the bug filter

This comment has been minimized.

Sign in to view

Copy link
@olleharstedt

olleharstedt Dec 29, 2017

Author Collaborator

It's doing asserts, so it has to extend TestCase, AFAIK.

This comment has been minimized.

Sign in to view

Copy link
@olleharstedt

olleharstedt Dec 29, 2017

Author Collaborator

Where did you get the error?

This comment has been minimized.

Sign in to view

Copy link
@TonisOrmisson

TonisOrmisson Dec 29, 2017

Collaborator

I just got a bit confused by the class not calling parent::__construct() and noticed the construct parameters were different. I was not sure if this was ok.

and also the folder name "helpers" kind of is misleading :)
{
/**
* If true, compares JS result with json_encode(PHP result)
Expand Down

0 comments on commit 6a9a1f1

Please sign in to comment.