Fixed issue 04420 group.php will strip out {QUESTION_ESSENTIALS} if i…

…t appears at the very first part of the template Dev substituted strpos() with preg_match() to fix stripping of {QUESTION_ESSENTIALS} Dev strip {QUESTION_CLASS} if {QUESTION_ESSENTIALS} is missing Dev this issue occured in question.php, group.php and survey.php so all have been updated git-svn-id: file:///Users/Shitiz/Downloads/lssvn/source/limesurvey@8909 b72ed6b6-b9f8-46b5-92b4-906544132732
LimeSurvey · Jul 7, 2010 · 6ca5411 · 6ca5411
1 parent 54a2f28
commit 6ca5411
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/group.php b/group.php
@@ -1096,10 +1096,11 @@ function checkconditions(value, name, type)
 
         $question_template = file_get_contents($thistpl.'/question.pstpl');
 
-        if( (strpos( $question_template , '{QUESTION_ESSENTIALS}') == false) || (strpos( $question_template , '{QUESTION_CLASS}') == false) )
+        if( preg_match( '/\{QUESTION_ESSENTIALS\}/' , $question_template ) === false || preg_match( '/\{QUESTION_CLASS\}/' , $question_template ) === false )
         {
             // if {QUESTION_ESSENTIALS} is present in the template but not {QUESTION_CLASS} remove it because you don't want id="" and display="" duplicated.
             $question_template = str_replace( '{QUESTION_ESSENTIALS}' , '' , $question_template );
+            $question_template = str_replace( '{QUESTION_CLASS}' , '' , $question_template );
             echo '
 	<!-- NEW QUESTION -->
 				<div id="question'.$qa[4].'" class="'.$q_class.$man_class.'"'.$n_q_display.'>

diff --git a/question.php b/question.php
@@ -512,10 +512,11 @@
 
             $question_template = file_get_contents($thistpl.'/question.pstpl');
 
-            if( (strpos( $question_template , '{QUESTION_ESSENTIALS}') == false) || (strpos( $question_template , '{QUESTION_CLASS}') == false) )
+            if( preg_match( '/\{QUESTION_ESSENTIALS\}/' , $question_template ) === false || preg_match( '/\{QUESTION_CLASS\}/' , $question_template ) === false )
             {
                 // if {QUESTION_ESSENTIALS} is present in the template but not {QUESTION_CLASS} remove it because you don't want id="" and display="" duplicated.
                 $question_template = str_replace( '{QUESTION_ESSENTIALS}' , '' , $question_template );
+                $question_template = str_replace( '{QUESTION_CLASS}' , '' , $question_template );
                 echo '
 	<!-- NEW QUESTION -->
 				<div id="question'.$qa[4].'" class="'.$q_class.$man_class.'"'.$n_q_display.'>

diff --git a/survey.php b/survey.php
@@ -900,10 +900,11 @@ function checkconditions(value, name, type)
 
                 $question_template = file_get_contents($thistpl.'/question.pstpl');
 
-                if( (strpos( $question_template , '{QUESTION_ESSENTIALS}') == false) || (strpos( $question_template , '{QUESTION_CLASS}') == false) )
+                if( preg_match( '/\{QUESTION_ESSENTIALS\}/' , $question_template ) === false || preg_match( '/\{QUESTION_CLASS\}/' , $question_template ) === false )
                 {
                     // if {QUESTION_ESSENTIALS} is present in the template but not {QUESTION_CLASS} remove it because you don't want id="" and display="" duplicated.
-                    $question_template = str_replace( '{QUESTION_ESSENTIALS}' , '' , $question_template );
+                   $question_template = str_replace( '{QUESTION_ESSENTIALS}' , '' , $question_template );
+                   $question_template = str_replace( '{QUESTION_CLASS}' , '' , $question_template );
 
                     echo '
 	<!-- NEW QUESTION -->