Fixed issue #16452: When admin previews surveys timer is not reset in…

… between runs (#1476)

On preview mode, set the 'resetQuestionTimers' js flag from server side, so timer.js can pick it and unset the localstorage (so, timer gets reset)

application/controllers/survey/index.php

@@ -593,6 +593,11 @@ public function action()
             initFieldArray($surveyid, $_SESSION['survey_'.$surveyid]['fieldmap']);
         }
 
+        // Reset the question timers in preview
+        if (!$isSurveyActive || $previewmode) {
+            resetQuestionTimers();
+        }
+
         sendCacheHeaders();
 
         //Send local variables to the appropriate survey type

application/helpers/frontend_helper.php

@@ -1943,7 +1943,7 @@ function killSurveySession($iSurveyID)
 
 /**
 * Resets all question timers by expiring the related cookie - this needs to be called before any output is done
-* @todo Make cookie survey ID aware
+* @todo Deprecated - Question timers no longer use cookies
 */
 function resetTimers()
 {
@@ -1952,6 +1952,14 @@ function resetTimers()
     Yii::app()->request->cookies['limesurvey_timers'] = $cookie;
 }
 
+/**
+* Sets the 'resetQuestionTimers' flag, so timer.js can pick it and unset the localstorage
+*/
+function resetQuestionTimers()
+{
+    Yii::app()->clientScript->registerScript('resetQuestionTimers', "LSvar.bResetQuestionTimers=true;", LSYii_ClientScript::POS_BEGIN);
+}
+
 /**
 * Set the public survey language
 * Control if language exist in this survey, else set to survey default language

assets/packages/questions/timer/src/timeclass.js

@@ -296,6 +296,10 @@ export default class TimerConstructor {
         this.intervalObject = null;
         this.warning = 0;
         this.timersessionname = 'timer_question_' + this.option.questionid;
+
+        // Unser timer in local storage if the reset timers flag is set
+        if (LSvar.bResetQuestionTimers) this._unsetTimerInLocalStorage();
+
         this.timeLeft = this._getTimerFromLocalStorage() || this.option.timer;
         this.disable_next = $("#disablenext-" + this.timersessionname).val();
         this.disable_prev = $("#disableprev-" + this.timersessionname).val();