Skip to content

Commit

Permalink
Dev : better fix #6309 : othercbox are not need, then hide in CSS
Browse files Browse the repository at this point in the history
  • Loading branch information
@Shnoulle
Shnoulle committed Jul 11, 2012
1 parent b4ffd76 commit 7465610
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion qanda.php
View file
Expand Up @@ -2334,7 +2334,7 @@ function do_multiplechoice($ia)
}
$answer .= $startitem;
$answer .= $hiddenfield.'
<input class="checkbox" type="checkbox" name="'.$myfname.'cbox" alt="'.$clang->gT('Other').'" id="answer'.$myfname.'cbox"';
<input class="checkbox" type="checkbox" name="'.$myfname.'cbox" alt="'.$clang->gT('Other').'" id="answer'.$myfname.'cbox" style="display:none"'; // othercbox can be not display, because only input text goes to database

if (isset($_SESSION[$myfname]) && trim($_SESSION[$myfname])!='')
{
Expand Down

3 comments on commit 7465610

@TMSWhite
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks array_filter, and is the source of complaints like this one - http://www.limesurvey.org/forum/design-issues/83961-other-options-within-multiple-choice-question-became-readonly-in-build-120725?lang=en#83961

I recommend reverting this.

Although this was meant as a better fix for #6309, I don't see how this helps.

@TMSWhite
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bug report for this filed here - http://bugs.limesurvey.org/view.php?id=6467

@Shnoulle
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then a display:hidden, or adpat the javascript. This don't change Expression Manager, and css don't have to be changed.

Its' allway difficult to click on "other cbox", a lot of user complain of clicking on it and don't see change.

Link on the forum is another problem (javacripting input.text readonly).

Please sign in to comment.