Fixed issue #17720: Wrong statistics with Other answers in single cho…

…ice questions (#2203) Co-authored-by: encuestabizdevgit <devgit@encuesta.biz>
LimeSurvey · Jan 11, 2022 · 74f4ee3 · 74f4ee3
1 parent 57beb3c
commit 74f4ee3
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/application/helpers/admin/statistics_helper.php b/application/helpers/admin/statistics_helper.php
@@ -1451,9 +1451,9 @@ protected function displaySimpleResults($outputs, $results, $rt, $outputType, $s
                         // just count the number of 'other' values - that way with failing Javascript the statistics don't get messed up
                         /* This query selects a count of responses where "other" has been selected */
                         foreach ($oResponses as $oResponse) {
-                            $sResponseColumn = $al[2];
-                            $column = substr($sResponseColumn, 0, strlen($sResponseColumn) - 5);
-                            if ($column == '-oth-' && !empty($oResponse->$sResponseColumn)) {
+                            $otherValueColumn = $al[2];
+                            $answerOptionColumn = substr($otherValueColumn, 0, strlen($otherValueColumn) - 5);
+                            if (!empty($oResponse->$answerOptionColumn) && $oResponse->$answerOptionColumn == '-oth-') {
                                 $row += 1;
                             }
                         }
@@ -2223,9 +2223,9 @@ protected function displayResults($outputs, $results, $rt, $outputType, $surveyi
                         // just count the number of 'other' values - that way with failing Javascript the statistics don't get messed up
                         /* This query selects a count of responses where "other" has been selected */
                         foreach ($oResponses as $oResponse) {
-                            $sResponseColumn = $al[2];
-                            $column = substr($sResponseColumn, 0, strlen($sResponseColumn) - 5);
-                            if ($column == '-oth-' && !empty($oResponse->$sResponseColumn)) {
+                            $otherValueColumn = $al[2];
+                            $answerOptionColumn = substr($otherValueColumn, 0, strlen($otherValueColumn) - 5);
+                            if (!empty($oResponse->$answerOptionColumn) && $oResponse->$answerOptionColumn == '-oth-') {
                                 $row += 1;
                             }
                         }