[feature] Allow to update runtime directory in config (LimeSurvey API…

… 3 compatible only)

CHANGELOG.md

@@ -5,6 +5,7 @@ Only partial changelog, [commit history](https://framagit.org/Shnoulle/LimeSurve
 
 ### Feature
 - Allow to update via cli
+- Allow to update runtime directory in config (LimeSurvey API 3 compatible only)
 
 ### [1.2.2] - 2016-01-12
 - Update [PHPMailer](https://github.com/PHPMailer/PHPMailer/releases/tag/v5.2.22) for security issue

application/commands/UpdateCommand.php

@@ -32,7 +32,7 @@ public function run(){
                 echo "Database has been successfully upgraded to version $newDbVersion \n";
             } else {
                 //echo gT("Please fix this error in your database and try again")."\n";
-                echo "Please fix this error in your database and try again\n";
+                throw new CException("Please fix this error in your database and try again");
             }
         } else {
             echo "no need update ".$newDbVersion ." ". $currentDbVersion ."\n";

application/config/config-defaults.php

@@ -610,7 +610,7 @@
 $config['standardtemplaterooturl'] = $config['publicurl'].'templates';      // Location of the standard templates
 $config['adminscripts']            = $config['publicurl'].'scripts/admin/';
 $config['generalscripts']          = $config['publicurl'].'scripts/';
-$config['third_party']                 = $config['publicurl'].'third_party/';
+$config['third_party']             = $config['publicurl'].'third_party/';
 $config['styleurl']                = $config['publicurl'].'styles/';
 $config['publicstyleurl']          = $config['publicurl'].'styles-public/';
 $config['sCKEditorURL']            = $config['third_party'].'ckeditor';
@@ -631,6 +631,9 @@
 
 // Use alias notation, we should move to this format everywhere.
 $config['plugindir']               = 'webroot.plugins';
+// This directory can be out of webroot directory
+// Usage of this config option broke 2.5X compatibility, introduced in 3.0 only
+$config['runtimedir']               = $config['tempdir'].DIRECTORY_SEPARATOR."runtime";
 
 // (javascript) Fix automatically the value entered in numeric question type : 1: remove all non numeric caracters; 0 : leave all caracters
 $config['bFixNumAuto']             = 1;