Fixed issue #10230: Limesurvey should not check completed surveys quotas

Dev: quota are strange with "allow edit response" actually Dev: submit with quota Dev: launch same survey again : allow to edit response
LimeSurvey · Mar 5, 2016 · 7a4392e · olleharstedt · Mar 5, 2016 · Shnoulle
1 parent b9f2bc9
commit 7a4392e
Showing 1 changed file with 9 additions and 2 deletions.
diff --git a/application/helpers/frontend_helper.php b/application/helpers/frontend_helper.php
@@ -1906,11 +1906,18 @@ function UpdateFieldArray()
 * checkCompletedQuota() returns matched quotas information for the current response
 * @param integer $surveyid - Survey identification number
 * @param bool $return - set to true to return information, false do the quota
-* @return array - nested array, Quotas->Members->Fields, includes quota information matched in session.
+* @return array|void - nested array, Quotas->Members->Fields, includes quota information matched in session.
 */
 function checkCompletedQuota($surveyid,$return=false)
 {
-    if (!isset($_SESSION['survey_'.$surveyid]['srid']))
+    /* Check is session is set */
+    if (!isset(App()->session['survey_'.$surveyid]['srid']))
+    {
+        return;
+    }
+    /* Check is Response is already submitted : only when "do" the quota: allow to send information about quota */
+    $oResponse=Response::model($surveyid)->findByPk(App()->session['survey_'.$surveyid]['srid']);
+    if(!$return && $oResponse && !is_null($oResponse->submitdate))
     {
         return;
     }