Fixed issue #11248: Saving plugin survey settings send PHP notice

Dev: remove the second call to same function
Dev: e8f6f76 child

application/controllers/admin/database.php

@@ -1073,7 +1073,7 @@ function index($sa = null)
             // Preload survey
             $oSurvey=Survey::model()->findByPk($iSurveyID);
 
-             // Save plugin settings.
+             // Save plugin settings : actually leave it before saving core : we are sure core settings is saved in LS way.
             $pluginSettings = App()->request->getPost('plugin', array());
             foreach($pluginSettings as $plugin => $settings)
             {
@@ -1159,11 +1159,6 @@ function index($sa = null)
             $oSurvey->adminemail = App()->request->getPost('adminemail');
             $oSurvey->bounce_email = App()->request->getPost('bounce_email');
 
-            $event = new PluginEvent('newSurveySettings');
-            $event->set('newSurvey', $oSurvey);
-            $event->set('survey', $iSurveyID);
-            App()->getPluginManager()->dispatchEvent($event);
-
             if ($oSurvey->save())
             {
                 Yii::app()->setFlashMessage(gT("Survey settings were successfully saved."));