Fixed issue #17121: Custom question preview image not shown (#1810)

LimeSurvey · Mar 25, 2021 · 8100d01 · 8100d01
1 parent 0ce1965
commit 8100d01
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 2 deletions.
diff --git a/application/helpers/update/updatedb_helper.php b/application/helpers/update/updatedb_helper.php
@@ -3757,7 +3757,21 @@ function ($v) {
             $oTransaction->commit();
         }
 
-        if ($iOldDBVersion < 442) { 
+        if ($iOldDBVersion < 442) {
+            $oTransaction = $oDB->beginTransaction();
+            $questionTheme = new QuestionTheme();
+            $questionsMetaData = $questionTheme->getAllQuestionMetaData(false, false, true)['available_themes'];
+            foreach ($questionsMetaData as $questionMetaData) {
+                $oQuestionTheme = QuestionTheme::model()->findByAttributes([
+                    "name" => $questionMetaData['name'],
+                    "extends" => $questionMetaData['questionType'],
+                    "theme_type" => $questionMetaData['type']
+                ]);
+                if (!empty($oQuestionTheme) && $oQuestionTheme->image_path != $questionMetaData['image_path']) {
+                    $oQuestionTheme->image_path = $questionMetaData['image_path'];
+                    $oQuestionTheme->save();
+                }
+            }
             $oTransaction = $oDB->beginTransaction();
             $oDB->createCommand()->insert("{{plugins}}", [
                 'name'               => 'TwoFactorAdminLogin',

diff --git a/application/models/QuestionTheme.php b/application/models/QuestionTheme.php
@@ -714,7 +714,7 @@ public static function findAllQuestionMetaDataForSelector()
             $baseQuestion['image_path'] = str_replace(
                 '//',
                 '/',
-                App()->getConfig('publicurl') . $baseQuestion['image_path']
+                Yii::app()->baseUrl . '/' . $baseQuestion['image_path']
             );
             $baseQuestionsModified[] = $baseQuestion;
         }