You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
93f161f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
About all this part : i really think we must throw clean 401/404/403 error, and have a clean ajax system to show the error in a box.
93f161f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. That's why I did the AjaxHelper before, but Markus chose not to adopt it. It should be removed and replaced by a system Markus wants.
93f161f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You + me + Louis think it's best to throw clean error, no ? (and use a AjaxHelper)
93f161f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clean error, yes, of course, but Markus is responsible for the JavaScript parts of LS right now, so it should be up to him to design a solution.
93f161f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A solution that fits with his other code, I mean.