Fixed issue #06171: variable < X is true even if variable isn't answered

Dev This now works automatically for authors who use the conditions editor Dev To bulk-convert the entire database, call http://localhost/limesurvey/index.php/admin/expressions/upgrade_conditions2relevance Dev Authors who manually enter relevance equations must pay more attention to the upgrade hints - http://docs.limesurvey.org/Upgrade+hints+for+version+1.92#Mathematical_comparisons_against_empty_no_responses
LimeSurvey · Jun 5, 2012 · 9a329a9 · 9a329a9
1 parent 462912a
commit 9a329a9
Show file tree

Hide file tree

Showing 2 changed files with 65 additions and 8 deletions.
diff --git a/application/helpers/expressions/em_core_helper.php b/application/helpers/expressions/em_core_helper.php
@@ -2569,6 +2569,17 @@ static function UnitTestEvaluator()
 1~!0
 0~(empty and 0)
 0~(empty or 0)
+<B>Empty_Var Vs. Zero</B>~"<B>Empty_Var Vs. Zero</B>"
+0~empty == zero
+1~empty != zero
+0~empty > zero
+0~empty >= zero
+0~empty < zero
+0~empty <= zero
+1~!empty
+1~!zero
+0~(empty and zero)
+0~(empty or zero)
 <B>Empty_Var Vs. Constant</B>~"<B>Empty_Var Vs. Constant</B>"
 0~empty == 3
 1~empty != 3
@@ -2590,6 +2601,16 @@ static function UnitTestEvaluator()
 0~!is_empty(empty) && (empty <= 0)
 0~!is_empty(empty) && ((empty and 0))
 0~!is_empty(empty) && ((empty or 0))
+<B>Solution: Empty_Var Vs. Zero</B>~"<B>Solution: Empty_Var Vs. Zero</B>"
+0~!is_empty(empty) && (empty == zero)
+0~!is_empty(five) && (five == zero)
+1~!is_empty(zero) && (zero == zero)
+0~!is_empty(empty) && (empty > zero)
+0~!is_empty(empty) && (empty >= zero)
+0~!is_empty(empty) && (empty < zero)
+0~!is_empty(empty) && (empty <= zero)
+0~!is_empty(empty) && ((empty and zero))
+0~!is_empty(empty) && ((empty or zero))
 <B>Solution: Empty_Var Vs. Constant</B>~"<B>Solution: Empty_Var Vs. Constant</B>"
 0~!is_empty(empty) && (empty < 3)
 0~!is_empty(empty) && (empty <= 3)
@@ -2600,6 +2621,7 @@ static function UnitTestEvaluator()
 1~(empty != 0)
 1~!is_empty(empty) && (empty != 0)
 1~is_empty(empty) || (empty != 0)
+1~is_empty(empty) || (empty != zero)
 0~is_empty(zero) || (zero != 0)
 1~is_empty(five) || (five != 0)
 <b>SETUP</b>~'<b>SETUP</b>'

diff --git a/application/helpers/expressions/em_manager_helper.php b/application/helpers/expressions/em_manager_helper.php
@@ -791,6 +791,7 @@ public static function ConvertConditionsToRelevance($surveyId=NULL, $qid=NULL)
             $relOrList = array();
             foreach($query->readAll() as $row)
             {
+                $row['method']=trim($row['method']); //For Postgres
                 if ($row['qid'] != $_qid)
                 {
                     // output the values for prior question is there was one
@@ -884,18 +885,52 @@ public static function ConvertConditionsToRelevance($surveyId=NULL, $qid=NULL)
                 {
                     // Conditions uses ' ' to mean not answered, but internally it is really stored as ''.  Fix this
                     if ($value === '" "') {
-                        if ($row['method'] == '==') {
+                        if ($row['method'] == '==')
+                        {
                             $relOrList[] = "is_empty(" . $fieldname . ")";
                         }
-                        else if ($row['method'] == '!=') {
-                                $relOrList[] = "!is_empty(" . $fieldname . ")";
-                            }
-                            else {
-                                $relOrList[] = $fieldname . " " . $row['method'] . " " . $value;
+                        else if ($row['method'] == '!=')
+                        {
+                            $relOrList[] = "!is_empty(" . $fieldname . ")";
+                        }
+                        else
+                        {
+                            $relOrList[] = $fieldname . " " . $row['method'] . " " . $value;
                         }
                     }
-                    else {
-                        $relOrList[] = $fieldname . " " . $row['method'] . " " . $value;
+                    else
+                    {
+                        if ($value == '"0"' || !preg_match('/^".+"$/',$value))
+                        {
+                            switch ($row['method'])
+                            {
+                                case '==':
+                                case '<':
+                                case '<=':
+                                case '>=':
+                                    $relOrList[] = '(!is_empty(' . $fieldname . ') && (' . $fieldname . " " . $row['method'] . " " . $value . '))';
+                                    break;
+                                case '!=':
+                                    $relOrList[] = '(is_empty(' . $fieldname . ') || (' . $fieldname . " != " . $value . '))';
+                                    break;
+                                default:
+                                    $relOrList[] = $fieldname . " " . $row['method'] . " " . $value;
+                                    break;
+                            }
+                        }
+                        else
+                        {
+                            switch ($row['method'])
+                            {
+                                case '<':
+                                case '<=':
+                                    $relOrList[] = '(!is_empty(' . $fieldname . ') && (' . $fieldname . " " . $row['method'] . " " . $value . '))';
+                                    break;
+                                default:
+                                    $relOrList[] = $fieldname . " " . $row['method'] . " " . $value;
+                                    break;
+                            }
+                        }
                     }
                 }