Fixed issue #16982: Server error if template are invalid

Dev: setOptions after fix current template
Dev: Cherry-picked

application/models/Survey.php

@@ -543,7 +543,9 @@ public function rules()
 
     /**
      * afterFindSurvey to fix and/or add some survey attribute
+     * - event afterFindSurvey (for all attributes)
      * - Fix template name to be sure template exist
+     * - setOptions for inherited value
      */
     public function afterFindSurvey()
     {
@@ -556,13 +558,11 @@ public function afterFindSurvey()
                 $this->setAttribute($attribute,$event->get($attribute));
             }
         }
-
-        // set inherited values for existing survey
-        $this->setOptions($this->gsid);
-
         if ($this->template != 'inherit'){
             $this->template = Template::templateNameFilter($this->template);
         }
+        /* this is fixed, setOptions for inherited after all */
+        $this->setOptions($this->gsid);
     }