Dev: Re-fix issue #09828 : adding subquestion multiple times update m…

…ax_subquestions Dev: Adding attribute only if not exist Dev: related d09e6d4#diff-4c8b6e0396ccd2f7fad4f57489b63b06L156 and #507
LimeSurvey · Aug 23, 2017 · 9cbb9ba · 9cbb9ba
1 parent c7553b4
commit 9cbb9ba
Showing 1 changed file with 9 additions and 8 deletions.
diff --git a/application/controllers/admin/database.php b/application/controllers/admin/database.php
@@ -152,17 +152,18 @@ function index($sa = null)
             /* @todo : add it to upgrage DB system, and see for the lsa */
             if($sQuestionType=="R" && Survey::model()->findByPk($iSurveyID)->active=="Y")
             {
-                QuestionAttribute::model()->find(
+                $oQuestionAttributeMaxSubQuestions = QuestionAttribute::model()->find(
                     "qid = :qid AND attribute = 'max_subquestions'",
                     array(':qid' => $iQuestionID)
                 );
-
-                $answerCount=Answer::model()->countByAttributes(array('qid' => $iQuestionID,'language'=>Survey::model()->findByPk($iSurveyID)->language));
-                $oQuestionAttribute = new QuestionAttribute();
-                $oQuestionAttribute->qid = $iQuestionID;
-                $oQuestionAttribute->attribute = 'max_subquestions';
-                $oQuestionAttribute->value = $answerCount;
-                $oQuestionAttribute->save();
+                if(!$oQuestionAttributeMaxSubQuestions) {
+                    $answerCount=Answer::model()->countByAttributes(array('qid' => $iQuestionID,'language'=>Survey::model()->findByPk($iSurveyID)->language));
+                    $oQuestionAttributeMaxSubQuestions = new QuestionAttribute();
+                    $oQuestionAttributeMaxSubQuestions->qid = $iQuestionID;
+                    $oQuestionAttributeMaxSubQuestions->attribute = 'max_subquestions';
+                    $oQuestionAttributeMaxSubQuestions->value = $answerCount;
+                    $oQuestionAttributeMaxSubQuestions->save();
+                }
 
             }