Fixed issue #16573: Others than the survey owners are not allowed to …

…edit questions anymore (#1547) Dev: actionGetQuestionPermissions was checking the 'survey' permission instead of 'surveycontent'.
LimeSurvey · Aug 19, 2020 · 9d09607 · 9d09607
1 parent 3712854
commit 9d09607
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/application/controllers/QuestionEditorController.php b/application/controllers/QuestionEditorController.php
@@ -585,11 +585,11 @@ public function actionGetQuestionPermissions($iQuestionId = null)
         $oQuestion = $this->getQuestionObject($iQuestionId);
 
         $aPermissions = [
-            "read" => Permission::model()->hasSurveyPermission($oQuestion->sid, 'survey', 'read'),
-            "update" => Permission::model()->hasSurveyPermission($oQuestion->sid, 'survey', 'update'),
+            "read" => Permission::model()->hasSurveyPermission($oQuestion->sid, 'surveycontent', 'read'),
+            "update" => Permission::model()->hasSurveyPermission($oQuestion->sid, 'surveycontent', 'update'),
             "editorpreset" => App()->session['htmleditormode'],
             "script" =>
-                Permission::model()->hasSurveyPermission($oQuestion->sid, 'survey', 'update')
+                Permission::model()->hasSurveyPermission($oQuestion->sid, 'surveycontent', 'update')
                 && SettingsUser::getUserSetting('showScriptEdit', App()->user->id),
         ];