Dev: Factor out getUserList()

LimeSurvey · Apr 7, 2016 · 9d289b7 · 9d289b7
1 parent f0efa6a
commit 9d289b7
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/application/controllers/admin/surveypermission.php b/application/controllers/admin/surveypermission.php
@@ -597,12 +597,13 @@ function delete($surveyid)
         $gid = App()->getRequest()->getParam('gid');
         $postuserid = (!empty($uid)) ? $uid : false;
         $postusergroupid = (!empty($gid)) ? $gid : false;// Not used
+        $userList = getUserList('onlyuidarray');
 
-        if($postuserid && !in_array($postuserid,getUserList('onlyuidarray')))
+        if($postuserid && !in_array($postuserid,$userList))
         {
             $this->getController()->error('Access denied');
         }
-        elseif( $postusergroupid &&  !in_array($postusergroupid,getUserList('onlyuidarray')))
+        elseif($postusergroupid && !in_array($postusergroupid, $userList))
         {
             $this->getController()->error('Access denied');
         }