Skip to content

Commit

Permalink
Fixed issue #16461: Twice contact sentence for some error page (#1469)
Browse files Browse the repository at this point in the history
Dev: remove duplicates, leave contact for theme only.
  • Loading branch information
Shnoulle committed Jul 15, 2020
1 parent dee1ed9 commit a1f72c4
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 5 deletions.
4 changes: 0 additions & 4 deletions application/controllers/survey/index.php
Expand Up @@ -308,7 +308,6 @@ public function action()
$aErrors = array(gT('Error'));
$aMessage = array(
gT("We are sorry but the survey is expired and no longer available."),
sprintf(gT("Please contact %s ( %s ) for further assistance."), $thissurvey['adminname'], $thissurvey['adminemail']) /* Maybe better to move this to a global replacement 'surveycontact' */
);

$event = new PluginEvent('onSurveyDenied');
Expand All @@ -330,7 +329,6 @@ public function action()
$aErrors = array(gT('Error'));
$aMessage = array(
gT("This survey is not yet started."),
sprintf(gT("Please contact %s ( %s ) for further assistance."), $thissurvey['adminname'], $thissurvey['adminemail'])/* Maybe better to move this to a global replacement 'surveycontact' */
);

$event = new PluginEvent('onSurveyDenied');
Expand All @@ -354,7 +352,6 @@ public function action()
$aErrors = array(gT('Error'));
$aMessage = array(
gT("You have already completed this survey."),
sprintf(gT("Please contact %s ( %s ) for further assistance."), $thissurvey['adminname'], $thissurvey['adminemail'])/* Maybe better to move this to a global replacement 'surveycontact' */
);

$event = new PluginEvent('onSurveyDenied');
Expand Down Expand Up @@ -473,7 +470,6 @@ public function action()

$aMessage = array(
gT("We are sorry but you are not allowed to enter this survey."),
sprintf(gT("Please contact %s ( %s ) for further assistance."), $thissurvey['adminname'], $thissurvey['adminemail'])/* Maybe better to move this to a global replacement 'surveycontact' */
);

$event = new PluginEvent('onSurveyDenied');
Expand Down
2 changes: 1 addition & 1 deletion themes/survey/vanilla/views/layout_errors.twig
Expand Up @@ -65,7 +65,7 @@
{% if aError.contact %}
{{ aError.contact }}
{% else %}
{{gT("For further information please contact %s:")|format (aSurveyInfo.adminname)}}
{{gT("For further information please contact %s:")|format (aSurveyInfo.admin)}}
{% if aSurveyInfo.adminemail %}
<br>
<a href='mailto:{{ aSurveyInfo.adminemail }}'>{{ aSurveyInfo.adminemail }}</a>
Expand Down

0 comments on commit a1f72c4

Please sign in to comment.