Fixed issue #13634: Internal Server Error on CDbCommand when edit user

Dev: just remove this uneeded )
LimeSurvey · Apr 26, 2018 · a2fcabb · a2fcabb
1 parent bd0c0f4
commit a2fcabb
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/application/controllers/admin/useraction.php b/application/controllers/admin/useraction.php
@@ -318,10 +318,10 @@ public function modifyuser()
     {
         if (Yii::app()->request->getParam('uid') != '') {
             $postuserid = (int) Yii::app()->request->getParam("uid");
-            if (
+            if ( /* @todo : move all this logic to Permission::model */
                 Permission::model()->hasGlobalPermission('superadmin', 'read') // Super admin have all right on user
                 || Yii::app()->session['loginID'] == $postuserid // User can edit himself
-                || (Permission::model()->hasGlobalPermission('users', 'update') && User::model()->count("uid=:uid AND parent_id=:parent_id)", array(':uid' => $postuserid, 'parent_id' => Yii::app()->session['loginID']))) // User with users update can only update own Users
+                || (Permission::model()->hasGlobalPermission('users', 'update') && User::model()->count("uid=:uid AND parent_id=:parent_id", array(':uid' => $postuserid, 'parent_id' => Yii::app()->session['loginID']))) // User with users update can only update own Users
             ) {
                 $oUser = User::model()->findByPk($postuserid);
                 $aData = array();