Skip to content

Commit

Permalink
Fixed issue #17506: Error while upgrading a database when using MSSQL
Browse files Browse the repository at this point in the history
  • Loading branch information
c-schmitz committed Aug 12, 2021
1 parent aa37aa8 commit a441518
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion application/helpers/update/updatedb_helper.php
Original file line number Diff line number Diff line change
Expand Up @@ -3529,7 +3529,7 @@ function db_upgrade_all($iOldDBVersion, $bSilent = false)
$aSurvey->bounceaccountpass
)
],
"sid=" . $aSurvey[sid]
"sid=" . $aSurvey['sid']
);
}
}
Expand Down

1 comment on commit a441518

@olleharstedt
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like Psalm could have detected this issue, if we used it on this file:

ERROR: UndefinedConstant - application/helpers/update/updatedb_helper.php:3532:43 - Const sid is not defined (see https://psalm.dev/020)
"sid=" . $aSurvey[sid]

I'll try to configure it.

Please sign in to comment.