Fixed issue #13366: Extending a theme creates world writable directories

LimeSurvey · Mar 5, 2018 · a53d5b1 · a53d5b1
1 parent 4c3c700
commit a53d5b1
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/application/controllers/admin/themes.php b/application/controllers/admin/themes.php
@@ -499,7 +499,7 @@ public function templatecopy()
 
                 if ($mkdirresult == 1) {
                     // We just copy the while directory structure, but only the xml file
-                    $oFileHelper->copyDirectory($copydirname, $newdirname, array('fileTypes' => array('xml', 'png', 'jpg')));
+                    $oFileHelper->copyDirectory($copydirname, $newdirname, array('fileTypes' => array('xml', 'png', 'jpg'), 'newDirMode' => 0755, 'newFileMode' => 0644 ));
                     //TemplateConfiguration::removeAllNodes($newdirname);
                     TemplateManifest::extendsConfig($copydir, $newname);
                     TemplateManifest::importManifest($newname, ['extends' => $copydir]);