Fixed issue: during vv export, output data was buffered and lead to o…

…ut of memory errors when exporting large quantities of answers.
LimeSurvey · Mar 27, 2014 · a6c7af1 · a6c7af1
1 parent 7461a73
commit a6c7af1
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/application/controllers/admin/export.php b/application/controllers/admin/export.php
@@ -701,7 +701,8 @@ public function vvexport()
             }
             $result = Yii::app()->db->createCommand($query)->query();
 
-            foreach ( $result->readAll() as $row )
+            echo $vvoutput;
+            foreach ($result as $row)
             {
                 foreach ( $fieldnames as $field )
                 {
@@ -743,14 +744,14 @@ public function vvexport()
                     $sun[]=$value;
                 }
 
-                $beach = implode($s, $sun);
-                $vvoutput .= $beach;
+                /* it is important here to stream output data, line by line
+                 * in order to avoid huge memory consumption when exporting large
+                 * quantities of answers */
+                echo implode($s, $sun)."\n";
 
                 unset($sun);
-                $vvoutput .= "\n";
             }
 
-            echo $vvoutput;
             exit;
         }
     }