Skip to content

Commit

Permalink
Fixed issue #16454: Sometimes, question_order is assigned from survey_id
Browse files Browse the repository at this point in the history
When deleting a question, the order of questions in the group were reassigned by calling updateQuestionOrder, but the survey ID was passed as starting position.
  • Loading branch information
gabrieljenik committed Jul 10, 2020
1 parent b8f2693 commit ac15ca8
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion application/models/Question.php
Expand Up @@ -428,7 +428,7 @@ public function delete()
$this->removeFromLastVisited();

if (parent::delete()) {
Question::model()->updateQuestionOrder($this->gid, $this->sid);
Question::model()->updateQuestionOrder($this->gid);
return true;
}
return false;
Expand Down

0 comments on commit ac15ca8

Please sign in to comment.