Dev: Better output from EM tests

LimeSurvey · Aug 28, 2017 · ad4cc94 · ad4cc94
1 parent 52329c9
commit ad4cc94
Showing 1 changed file with 11 additions and 4 deletions.
diff --git a/tests/helpers/ExpressionCoreHelperTest.php b/tests/helpers/ExpressionCoreHelperTest.php
@@ -154,7 +154,6 @@ public function testCompareNumberLtSpace()
 
     /**
      * Expression: '3' < 'A'
-     * @group me
      */
     public function testCompareNumberLtLetter()
     {
@@ -317,10 +316,10 @@ protected function compareExpression($sgqa, $value, $expression, $jsonEncode = t
 
         $em->RDP_Evaluate($expression);
 
-        $result = $em->GetResult();
+        $emResult = $em->GetResult();
 
         if ($jsonEncode) {
-            $result = json_encode($result);
+            $emResult = json_encode($emResult);
         }
 
         $errors = $em->RDP_GetErrors();
@@ -332,7 +331,15 @@ protected function compareExpression($sgqa, $value, $expression, $jsonEncode = t
         $nodeOutput = $this->runNode($js);
 
         $this->assertCount(1, $nodeOutput);
-        $this->assertEquals($result, $nodeOutput[0], 'JS and PHP must return same result: ' . $expression);
+        $this->assertEquals(
+            $emResult,
+            $nodeOutput[0],
+            sprintf(
+                'JS (%s) and PHP (%s) must return same result. Expression: ' . $expression,
+                $nodeOutput[0],
+                $emResult
+            )
+        );
     }
 
     /**