Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Dev: Revert "Dev Added new PluginEvent onBeginRequest (#1242)"
Dev: This reverts commit 7204d4d. Dev: This commit broke Travis.
- Loading branch information
b478314
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@olleharstedt Can you explain what exactly was causing problems with this commit? How can these few lines of code break Travis?
b478314
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @maziminke. As you can see in the travis log here: https://travis-ci.org/LimeSurvey/LimeSurvey/jobs/503614225
All tests after the installation test fails, meaning the installation does no longer work. The author of the PR will have to check why. Maybe the plugin manager is not loaded at that point?
b478314
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
related to https://bugs.limesurvey.org/view.php?id=14931 ?
Not totally related , but related to difference betwwen web an command :
LimeSurvey/LimeSurvey/framework/db/CDbCommand.php
PluginManager are different in the 2 …