Skip to content

Commit

Permalink
Dev: Revert "Dev Added new PluginEvent onBeginRequest (#1242)"
Browse files Browse the repository at this point in the history
Dev: This reverts commit 7204d4d.

Dev: This commit broke Travis.
  • Loading branch information
olleharstedt committed Apr 26, 2019
1 parent 159f74c commit b478314
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions application/core/LSYii_Application.php
Expand Up @@ -76,12 +76,6 @@ public function __construct($aApplicationConfig = null)
/* Construct CWebApplication */
parent::__construct($aApplicationConfig);

$this->onBeginRequest = function($event) {
Yii::app()->getPluginManager()->dispatchEvent(
new PluginEvent('onBeginRequest', $event)
);
};

/* Because we have app now : we have to call again the config (usage of Yii::app() for publicurl) */
$this->setConfigs();

Expand Down

3 comments on commit b478314

@maziminke
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@olleharstedt Can you explain what exactly was causing problems with this commit? How can these few lines of code break Travis?

@olleharstedt
Copy link
Collaborator Author

@olleharstedt olleharstedt commented on b478314 May 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @maziminke. As you can see in the travis log here: https://travis-ci.org/LimeSurvey/LimeSurvey/jobs/503614225

All tests after the installation test fails, meaning the installation does no longer work. The author of the PR will have to check why. Maybe the plugin manager is not loaded at that point?

@Shnoulle
Copy link
Collaborator

@Shnoulle Shnoulle commented on b478314 May 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

related to https://bugs.limesurvey.org/view.php?id=14931 ?

Not totally related , but related to difference betwwen web an command : LimeSurvey/LimeSurvey/framework/db/CDbCommand.php

PluginManager are different in the 2 …

Please sign in to comment.