Skip to content

Commit

Permalink
Fixed issue #14313: Top part of drop-down box on participants screen …
Browse files Browse the repository at this point in the history 
…is hidden
  • Loading branch information
@dominikvitt
dominikvitt committed Dec 4, 2018
1 parent c4195b9 commit b9ca9fe
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions assets/packages/adminbasics/css/lime-admin-common.css
View file
Expand Up @@ -1954,6 +1954,10 @@ h3,.h3 {
text-align: left;
}

.dropup {
position: fixed;
}

.has-link
{
cursor: pointer;
Expand Down

11 comments on commit b9ca9fe

@Shnoulle
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to do it via gulp : for .min. too for example.

But here : maybe container : 'body' fix the issue

@dominikvitt
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lime-admin-common.css file doesn't need to be minified, there is no .min file.

@Shnoulle
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh , yes , right … sorry :)

@Shnoulle
Copy link
Collaborator

@Shnoulle Shnoulle commented on b9ca9fe Dec 6, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have this
capture d ecran du 2018-12-06 09-53-48

Deactivated fixed : and i see the button again.

data-popover='body' can fix the issue , but surely better in javascript option

Oups, it's not popover, it's dropdown …

@dominikvitt
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just noticed that dropup disappears when more than 10 rows are selected on right side.
Is that the case you reported?
Can you confirm it?

Bug isn't related to this bug fix, it happened at least 1 week ago, can't tell when.

@Shnoulle
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sometimes : is here, sometimes not … seems to vbe when you mve to another tab (it just happen after the screenshot)
capture d ecran du 2018-12-06 13-22-56

And when it's not here : using dev tool to deactivate position:fixed show it again
capture d ecran du 2018-12-06 13-27-39
capture d ecran du 2018-12-06 13-27-52

Still don't like the position fixed even when it's here … it must be inside the bar …

Else : it's the overflow the issue , but we can't have overflow-y:visible with overflow-x:auto or scroll …

@dominikvitt
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works for me without problems, on Chrome, Firefox and Opera.
Did you clear browser cache?

@Shnoulle
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

debug at 2, and still here since yesterday …

@Shnoulle
Copy link
Collaborator

@Shnoulle Shnoulle commented on b9ca9fe Dec 6, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh : another issue : set display 100 result by page (and have more than 100 result) : unable to see the dropup.

What happen :

  1. Load page and grid
  2. tokenListActions is after then100 lines, a lot of chance to be out of screen
  3. Since position is fixed : it still out of screen …

You're right about height : have a minimum height on grid tbody fix the issue, but it's a table … adding a element in javascript before table ? With a float and clearfix ? Width set to 1px ?

Else : with firefox : open console (at bottom) : tokenListActions disappear …

@dominikvitt
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://getbootstrap.com/docs/3.3/components/#dropdowns
https://getbootstrap.com/docs/3.3/javascript/#dropdowns
There are no data elements or JS methods which could be used.
More functionalities would be available from version 4.

So, only way to do it is via CSS.

@Shnoulle
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a wrapper on table fix the issue

Please sign in to comment.