-
Notifications
You must be signed in to change notification settings - Fork 986
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Dev: Multiple choice with comments, option 'other', few improvements …
…based on visCausCity request
- Loading branch information
LouisGac
committed
Jun 13, 2016
1 parent
9a6a205
commit bb172fe
Showing
4 changed files
with
28 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -953,3 +953,8 @@ label, th { | |
div.yes-no .btn-group label { | ||
white-space:normal; | ||
} | ||
|
||
|
||
.multipleco-other-topic { | ||
max-width: 150px; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bb172fe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
Why this sentence in placeholder ? Seems very specific, no ?
bb172fe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree.
bb172fe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was a request from a user yesterday in the IRC.
He expected the other item to behave like the other item, just having 'Other:' and an input box for the comment, instead of the two input boxes, which is very confusing for most people.
So, we should make clear what is expected in each input box, so people understand. I just used the words he suggested, they could be changed, of course.
bb172fe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a question attribute to set the placeholder texts.