Skip to content

Commit

Permalink
Dev: Multiple choice with comments, option 'other', few improvements …
Browse files Browse the repository at this point in the history
…based on visCausCity request
  • Loading branch information
LouisGac committed Jun 13, 2016
1 parent 9a6a205 commit bb172fe
Show file tree
Hide file tree
Showing 4 changed files with 28 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,8 @@
</div>

<input
class="text other form-control input-sm <?php echo $classes; echo $kpclass;?>"
class="text other form-control input-sm multipleco-other-topic <?php echo $classes; echo $kpclass;?>"
placeholder="<?php eT('Insert topic here'); ?>"
type="text"
name="<?php echo $name; ?>"
id="<?php echo $id;?>"
Expand Down Expand Up @@ -71,6 +72,7 @@ class="text other form-control input-sm <?php echo $classes; echo $kpclass;?>"

<input
class='form-control text input-sm <?php echo $kpclass; ?>'
placeholder="<?php eT('Elaborate here'); ?>"
type='text'
size='40'
id='<?php echo $inputCommentId;?>'
Expand Down
5 changes: 5 additions & 0 deletions templates/default/css/template.css
Original file line number Diff line number Diff line change
Expand Up @@ -953,3 +953,8 @@ label, th {
div.yes-no .btn-group label {
white-space:normal;
}


.multipleco-other-topic {
max-width: 150px;
}
12 changes: 10 additions & 2 deletions templates/news_paper/css/template.css
Original file line number Diff line number Diff line change
Expand Up @@ -946,7 +946,15 @@ label, th {
top: 10px;
}

.list-unstyled.radio-list
{
.list-unstyled.radio-list {
padding-left: 15px;
}

div.yes-no .btn-group label {
white-space:normal;
}


.multipleco-other-topic {
max-width: 150px;
}
12 changes: 10 additions & 2 deletions templates/ubuntu_orange/css/template.css
Original file line number Diff line number Diff line change
Expand Up @@ -946,7 +946,15 @@ label, th {
top: 10px;
}

.list-unstyled.radio-list
{
.list-unstyled.radio-list {
padding-left: 15px;
}

div.yes-no .btn-group label {
white-space:normal;
}


.multipleco-other-topic {
max-width: 150px;
}

4 comments on commit bb172fe

@Shnoulle
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?
Why this sentence in placeholder ? Seems very specific, no ?

@c-schmitz
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree.

@LouisGac
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was a request from a user yesterday in the IRC.
He expected the other item to behave like the other item, just having 'Other:' and an input box for the comment, instead of the two input boxes, which is very confusing for most people.
So, we should make clear what is expected in each input box, so people understand. I just used the words he suggested, they could be changed, of course.

@c-schmitz
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a question attribute to set the placeholder texts.

Please sign in to comment.