Fixed issue #14763: Slider didn't have label

Dev: use existing labelleby of input
LimeSurvey · Apr 12, 2019 · bc5c360 · bc5c360
1 parent d72a8a6
commit bc5c360
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/application/views/survey/questions/answer/multiplenumeric/rows/sliders/answer_row.twig b/application/views/survey/questions/answer/multiplenumeric/rows/sliders/answer_row.twig
@@ -44,7 +44,7 @@
                             'class': 'form-control answer-item numeric-item hidden',
                             'id' : "answer" ~ myfname ~ "slid", 
                         })
-                    }}                
+                    }}
                     {{ C.Html.textField( myfname, dispVal ,{
                             'class': 'form-control answer-item numeric-item ls-js-hidden slider-untouched',
                             'id' : "answer" ~ myfname,

diff --git a/assets/packages/questions/numeric-slider/scripts/numeric-slider.js b/assets/packages/questions/numeric-slider/scripts/numeric-slider.js
@@ -156,12 +156,15 @@ var LSSlider = function (options) {
                 // document.styleSheets[0].addRule('#' + elementObject.attr('id') + ' .slider-handle.custom::before', '{ content: "' + custom_handle + '" }');
             }
             sliderObject = new Slider(elementObject[0], createSliderSettings());
+            /* a11y : slider need a label */
+            if(rootElementObject.attr("aria-labelledby") && $(sliderObject.getElement()).find("[role='slider']:not('.hide')").length) {
+                $(sliderObject.getElement()).find("[role='slider']:not('.hide')").attr("aria-labelledby",rootElementObject.attr("aria-labelledby"));
+            }
             if(rootElementObject.val() === "") {
                 sliderObject.$sliderElem.addClass('slider-untouched');
                 if(setPosition) {
                     triggerChanges();
                 }
-
             } else {
                 sliderObject.setValue(rootElementObject.val().toString().replace(separator,'.'), true, true);
             }