Dev: CPDB attributes would be multi encrypted/decrypted when editing …

…values or loading them
LimeSurvey · Jul 26, 2021 · d1eb8af · d1eb8af
1 parent d4b51e6
commit d1eb8af
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/application/models/LSActiveRecord.php b/application/models/LSActiveRecord.php
@@ -435,10 +435,8 @@ public function decryptEncryptAttributes($action = 'decrypt')
         // TODO: Use OOP polymorphism instead of switching on class names.
         if ($class === 'ParticipantAttribute') {
             $aParticipantAttributes = CHtml::listData(ParticipantAttributeName::model()->findAll(["select" => "attribute_id", "condition" => "encrypted = 'Y' and core_attribute <> 'Y'"]), 'attribute_id', '');
-            foreach ($aParticipantAttributes as $attribute => $value) {
-                if (array_key_exists($this->attribute_id, $aParticipantAttributes)) {
-                    $this->value = $sodium->$action($this->value);
-                }
+            if (array_key_exists($this->attribute_id, $aParticipantAttributes)) {
+                $this->value = $sodium->$action($this->value);
             }
         } else {
             $attributes = $this->encryptAttributeValues($this->attributes, true, false);