Fixed issue: DB error when trying to activate already activated survey

LimeSurvey · Oct 19, 2020 · d8ca09d · d8ca09d
1 parent 637b283
commit d8ca09d
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/application/helpers/remotecontrol/remotecontrol_handle.php b/application/helpers/remotecontrol/remotecontrol_handle.php
@@ -442,7 +442,7 @@ public function set_survey_properties($sSessionKey, $iSurveyID, $aSurveyData)
      * Activate survey (RPC function)
      *
      * Return the result of the activation
-     * Failure status : Invalid Survey ID, Constistency check error, Activation Error, Invalid session key, No permission
+     * Failure status : Invalid Survey ID, Survey already active, Consistency check error, Activation Error, Invalid session key, No permission
      *
      * @access public
      * @param string $sSessionKey Auth credentials
@@ -457,6 +457,9 @@ public function activate_survey($sSessionKey, $iSurveyID)
             if (is_null($oSurvey)) {
                 return array('status' => 'Error: Invalid survey ID');
             }
+            if ($oSurvey->isActive) {
+                return array('status' => 'Error: Survey already active');
+            }
             // Check consistency for groups and questions
             Yii::app()->loadHelper('admin/activate');
             $checkHasGroup = checkHasGroup($iSurveyID);