Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fixed issue #09906: Invalid survey is set finished in response table …
…with index complete Dev: the first move set 'completed' to reponse table, then even if coma back : response tabke is set 'completed' and token 'uncompleted' Dev: SurveyRuntimeHelper become more an more complicated .... Dev: a good reason to add event to move 'index' to plugin ..... no ?
- Loading branch information
d9d3062
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should:
$thissurvey['questionindex']==2
be
$thissurvey['questionindex']>=2
?
Is is okay to backport to v2.05 since you said in the bug #09906 you had fixed it for it earlier?
d9d3062
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
questionindex == 2 or >= 2 : actually we only support 0,1,2 . I don't know what we do for 3.
2.05 is not updated actualy.
d9d3062
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the info. Can keep it in mind when another numbered feature is used in the code.
d9d3062
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can I include this commit into v2.05 - will it break anything?
d9d3062
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this fix is OK in last 2.05.
d9d3062
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Committed.
apmuthu@c9717e1