Skip to content

Commit

Permalink
Fixed issue : No save button when add Question
Browse files Browse the repository at this point in the history
Dev: some $params[$key] seems needed ?
  • Loading branch information
Shnoulle committed Sep 4, 2019
1 parent de7707d commit e13cbeb
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions application/core/Survey_Common_Action.php
Expand Up @@ -129,13 +129,12 @@ private function _addPseudoParams($params)
// Chek is 2 params are equal for security issue.
foreach ($pseudos as $key => $pseudo) {
// We care only for user parameters, not by code parameters (see issue #15221)
if (Yii::app()->getRequest()->getParam($key)) {
$params[$key] = Yii::app()->getRequest()->getParam($key);
if ($checkParam = Yii::app()->getRequest()->getParam($key)) {
$pseudo = (array) $pseudo;
foreach ($pseudo as $pseud) {
if (empty($params[$pseud])) {
$params[$pseud] = $params[$key];
} elseif($params[$pseud] != $params[$key]){
$params[$pseud] = $checkParam;
} elseif($params[$pseud] != $checkParam){
// Throw error about multiple params (and if they are different) #15204
throw new CHttpException(403, sprintf(gT("Invalid parameter %s (%s already set)"),$pseud,$key));
}
Expand Down

0 comments on commit e13cbeb

Please sign in to comment.