Fixed issue #4957 : php alert in template editor

Dev : best test ....

git-svn-id: file:///Users/Shitiz/Downloads/lssvn/source/limesurvey@9788 b72ed6b6-b9f8-46b5-92b4-906544132732

admin/templates.php

@@ -266,22 +266,24 @@
    }
 }
 
-if ($action == "templaterename" && isset($newname) && isset($copydir) && (!in_array($newname,$standardtemplates))) 
+if ($action == "templaterename" && isset($newname) && isset($copydir)) 
+{
+    $newdirname=$usertemplaterootdir."/".$newname;
+    $olddirname=$usertemplaterootdir."/".$copydir;
+    if(isStandardTemplate($newname))
     {
-    if (isStandardTemplate($newname)){
         echo "<script type=\"text/javascript\">\n<!--\nalert(\"".sprintf($clang->gT("Template could not be renamed to `%s`.","js"), $newname)." ".$clang->gT("This name is reserved for standard template.","js")."\");\n//-->\n</script>";
     }
-    $newdirname=$usertemplaterootdir."/".$newname;
-    $olddirname=$usertemplaterootdir."/".$copydir;
-    if (rename($olddirname, $newdirname)==false) {
+    elseif (rename($olddirname, $newdirname)==false)
+    {
        echo "<script type=\"text/javascript\">\n<!--\nalert(\"".sprintf($clang->gT("Directory could not be renamed to `%s`.","js"), $newname)." ".$clang->gT("Maybe you don't have permission.","js")."\");\n//-->\n</script>";
-        } 
+    }
     else 
-        {
+    {
         $templates[$newname]=$newdirname;
         $templatename=$newname;
-        }
     }
+}
 
 if ($action == "templateuploadfile")
 {