Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fixed issue: Wrong informations in the error message, changed chmod r…
…ights
- Loading branch information
LouisGac
committed
May 18, 2015
1 parent
8b94e81
commit e900401
Showing
7 changed files
with
1 addition
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
Empty file.
Empty file.
Empty file.
Empty file.
Empty file.
e900401
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suphp can need 750 ;) for example, me i only need 700, some user can need 777 ....
e900401
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It supposes to work with a standard LAMP installation.
With a fresh Ubuntu LAMP installation, changing the runtimePath rights to 755 or 775 just doesn't work, and leaves the error message to : "change the runtimePath rights to 755 or 775".
By the way, it's normal. 755 means : "readable only for group or other", not writable.
Same with 700 wich means : "non readable or writable for group or other".
777 should not be needed (listing the directory or executing some files)
The only way to get it to work with a 700 or a 755 would be to change the directory owner to the web user. But, that is not what is asked in the message.
The most "normal way to do" would be just to ask to user to make writable the runtime directory, leaving him the choice of how to do it. But the message "should be writable by the webserver (755 or 775)" didn't worked in any cases, and the message "should be writable by the webserver (766 or 776)" will work in any cases.
During all the installation process, there is various bugs like this one about directories rights, they should be checked and corrected.
e900401
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, yes but you can never have the "all" accepted rigths in al server ;)
e900401
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What was doing the code here :
Checking if the directory is writable, and if not, sending an error message.
If the directory was not writable, changing its right to 755 would absolutely NEVER make it writable in any cases. Never.
Changing the right to 766 will make the directory writable by the web user : always, in any case.
e900401
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
e900401
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't make any suggestion, just say : "We can not have always rigth" ;) . For example: 766 break some suphp configuration :)
e900401
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This quick change is ok, it respects the original idea (it's the same text, with the good rights).
As I said : I've seen others bugs of this kind during the installation process, one generating a Yii error page. As said in the comment (the TODO), all those checks should be done inside the installer itself. But it's not a priority.
e900401
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shnoulle : the sentence "should be writable by the webserver (755 or 775)" was wrong.
why so much debate ?