Skip to content

Commit

Permalink
Fixed issue #13365: custom.css never gets loaded
Browse files Browse the repository at this point in the history
Fixed issue: some options not loaded on uninheriting the parent theme
  • Loading branch information
lacrioque committed Feb 16, 2018
1 parent 92dafe0 commit eba40fd
Show file tree
Hide file tree
Showing 5 changed files with 508 additions and 384 deletions.
2 changes: 1 addition & 1 deletion application/models/TemplateConfiguration.php
Expand Up @@ -632,7 +632,7 @@ public function getOptionPage()
$oTemplate->setOptions();
$oTemplate->setOptionInheritance();

$renderArray['oParentOptions'] = (array) $oTemplate->oOptions;
$renderArray['oParentOptions'] = array_merge(((array) $oTemplate->oOptions), array('packages_to_load' => json_encode($oTemplate->packages_to_load), 'files_css' => json_encode($oTemplate->files_css)));

This comment has been minimized.

Copy link
@LouisGac

LouisGac Feb 16, 2018

Contributor

but... this is not needed in options?

This comment has been minimized.

Copy link
@lacrioque

lacrioque Feb 16, 2018

Author Contributor

Yes, this is not needed in options.
But it is necessary to be used as a inherit value for switching from a fully inherited property to a partly inherited value.

return Yii::app()->twigRenderer->renderOptionPage($oTemplate, $renderArray);
}
Expand Down

0 comments on commit eba40fd

Please sign in to comment.